Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mountpoint: add page #2963

Merged
merged 3 commits into from
May 1, 2019
Merged

mountpoint: add page #2963

merged 3 commits into from
May 1, 2019

Conversation

lbonanomi
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

This PR is in support of #2214

@mebeim mebeim added the new command Issues requesting creation of a new page. label Apr 30, 2019
@mebeim
Copy link
Member

mebeim commented Apr 30, 2019

Thank you for the page @lbonanomi. Please remember to use the appropriate commit messages though, like the one you used for the title of this PR 🙂

@owenvoke
Copy link
Member

owenvoke commented May 1, 2019

@mebeim, it's fine to not use the commit message format most of the time when adding a new page as we squash it anyway. 👍

@mebeim
Copy link
Member

mebeim commented May 1, 2019

Yeah I know, that still requires a little more work though:

image

and becomes a problem when there are multiple commits (not in this case, but still). In general it's better to follow the commit message style guide.

@mebeim mebeim merged commit da2344c into tldr-pages:master May 1, 2019
@lbonanomi lbonanomi deleted the mountpoint branch May 1, 2019 11:49
@lbonanomi
Copy link
Contributor Author

lbonanomi commented May 1, 2019

FWIW @mebeim is absolutely right, commit message requirements are right there in the manual. I will make a point to be more cognizant of this in the future.

Thank you all for your hard work on this project and your continuing patience with my antics.

@mebeim
Copy link
Member

mebeim commented May 1, 2019

NP @lbonanomi thank you so much for the new pages 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants